Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

254 - Endpoint Configuration for vet_verification_status #10480

Merged
merged 4 commits into from
Mar 8, 2025
Merged

254 - Endpoint Configuration for vet_verification_status #10480

merged 4 commits into from
Mar 8, 2025

Conversation

matt-guest-wilcore
Copy link
Contributor

Description of Change

Added the new vet_verification_status endpoint to the mobile app with unit tests. We can now successfully query the endpoint to check a veterans Title 38 status.

Original Ticket

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

See ticket above for more detail. Verify the different responses and that data comes back as expected.

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

Matthew Guest - Work added 3 commits March 6, 2025 12:44
Added new vets_verification_status endpoint into the app
1c64c07
Added a test file that tests the query function getVeteranStatus. The…
db83e7c 
…se tests cover all the various responses and reasons we can get back from the vet_verification_status endpoint.
Updated some function text.
54bc10b
@matt-guest-wilcore matt-guest-wilcore requested review from a team as code owners March 6, 2025 23:50
@matt-guest-wilcore matt-guest-wilcore merged commit c83830c into develop Mar 8, 2025
76 of 78 checks passed
@matt-guest-wilcore matt-guest-wilcore deleted the chore/254/EndpointConfigurationForVeteranStatus branch March 8, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddballdave oddballdave oddballdave approved these changes

@mdewey mdewey Awaiting requested review from mdewey mdewey is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@ATeal ATeal Awaiting requested review from ATeal ATeal is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@rtwell rtwell Awaiting requested review from rtwell rtwell is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@ryan-mcneil ryan-mcneil Awaiting requested review from ryan-mcneil ryan-mcneil is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@kimmccaskill-oddball kimmccaskill-oddball Awaiting requested review from kimmccaskill-oddball kimmccaskill-oddball is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-With QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-guest-wilcore @oddballdave